Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for new iron version 0.7 with hyper 0.12 #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zgtm
Copy link

@zgtm zgtm commented Feb 11, 2019

This PR adapts to the changed types in iron (StatusCode, Request).

@zgtm zgtm self-assigned this Feb 11, 2019
Copy link
Author

@zgtm zgtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently somewhere something goes still wrong when reading GET query parameters.

@@ -78,7 +78,7 @@ impl Key for UrlEncodedQuery {
type Value = QueryMap;
}

impl<'a, 'b> plugin::Plugin<Request<'a, 'b>> for UrlEncodedQuery {
impl plugin::Plugin<Request> for UrlEncodedQuery {
type Error = UrlDecodingError;

fn eval(req: &mut Request) -> QueryResult {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

req.url.query() seems to fail or something, at least in my testrun it did not give me any data …

@zgtm
Copy link
Author

zgtm commented Feb 17, 2019

Okay, PR iron/iron#604 fixes reading query strings form the response, so everything should work here, after it is merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant