fix(brace-expansion): ignore only blocks that begins with $

[roggervalf]

this pr upgrades brace-expansion package that has this fix

[roggervalf]

Please @isaacs when you get some chance could you review this pr?

[isaacs]

This doesn't seem like correct behavior, though.

$ echo {a,b}\${c,d}\${e,f}
a$c$e a$c$f a$d$e a$d$f b$c$e b$c$f b$d$e b$d$f

Minimatch doesn't do ${} expansion, only {,,} expansion. Ignoring ${} sections seems wrong, no?

[roggervalf]

This doesn't seem like correct behavior, though.

$ echo {a,b}\${c,d}\${e,f}
a$c$e a$c$f a$d$e a$d$f b$c$e b$c$f b$d$e b$d$f

Minimatch doesn't do ${} expansion, only {,,} expansion. Ignoring ${} sections seems wrong, no?

@isaacs from your example, I could reproduce it, you are right, it seems this is a bug in brace-expand that do not consider when $ is present and I created a pr to fix it juliangruber/brace-expansion#58

[isaacs]

I don't think that brace-expand should be doing anything with $ at all, escaped or not. juliangruber/brace-expansion#58 (comment)