-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form-system-backend): Add functionality to create and edit custom lists #15352
Conversation
…into form-builder
…cript, removed all console.logs and removed all code that was commented out
…into form-builder
…n + script to generate graphql schemas
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15352 +/- ##
==========================================
+ Coverage 36.97% 37.01% +0.03%
==========================================
Files 6567 6560 -7
Lines 134328 134206 -122
Branches 38429 38390 -39
==========================================
+ Hits 49668 49671 +3
+ Misses 84660 84535 -125
Flags with carried forward coverage won't be shown. Click here to find out more. see 82 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There's still a missing infra definition for the service, you can consult with the devops team on that. |
…rm-system-backend-client
…d-is/island.is into form-system-backend-client
…d-is/island.is into form-system-backend-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infra LGTM
…m lists (#15352) * form builder 'init' * Added functionality for relevant parties * redirect to the correct url when creating a new form * removed secret from comment * chore: nx format:write update dirty files * Property number component * Fixed the header * Reverted to next 13.3.0 * Deleted the e2e project, updated to project to adhere to strict typescript, removed all console.logs and removed all code that was commented out * chore: nx format:write update dirty files * Started implementing zod validation * chore: nx format:write update dirty files * Generated a nestjs client from our openapi schema * Generated a client and created a domain client for graphql * Update Form, Group, Input, and Step DTOs * Refactor input settings in FormsService and Input model * Update API and authentication configurations * Added form-system client and module to the app/api and added a codegen + script to generate graphql schemas * Remove form-system module and add formSystemNavigation to masterNavigation * Refactor form-system API code and formBuilder into portals/admin * Fixng typing erros in form system graphql domain * Added another Object type and a bunch of inputTypes in order for codegen to work * Update import statements for LanguageTypeInput * Update form system module and related files * Update FormSystemClient.config and Forms component * Saving progress * Working version. Current issue: inputsettings are not being saved due to graphql not handling type discriminators * took out the formsysteminputsettings and replaced it with a graphqlTypeJson * spring cleaning and creating dependencies within the form * removed form-builder app * chore: charts update dirty files * chore: nx format:write update dirty files * form-system backend initial commit * initial configuration * adjust for PR * fix lint warnings * add models and modules * helstu módel, services og controllerar * make lint satisfied * Add functionality to create and edit custom lists * application part start * change step to section and group to page * tiny lint things * change naming of page to screen * changed naming of input to field * fix lint warnings * change naming of input to field * work on application part * change tablenames to singular * changed naming of testimony to certification * fixing apiproperty configurations * changed naming of urlName to slug * introduce lodash pick * refactor vegna PR * add openapi.yaml build * Refactor project setup * Add class validation for CreateFormDto * add class-validation * use predefined types for cases in switch * Fix build * Fix lint * Update tags * Remove empty test files * Skip tests until implemented * Add advania as codeowner for new service * add infra definition * add the service to uber-charts * chore: charts update dirty files * update grantNamespaces * chore: charts update dirty files * added seed instruction to DLS * chore: charts update dirty files --------- Co-authored-by: Hyo-Sam Nandkisore <[email protected]> Co-authored-by: andes-it <[email protected]> Co-authored-by: Sævar Már Atlason <[email protected]> Co-authored-by: Bæring Gunnar Steinþórsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…m lists (#15352) * form builder 'init' * Added functionality for relevant parties * redirect to the correct url when creating a new form * removed secret from comment * chore: nx format:write update dirty files * Property number component * Fixed the header * Reverted to next 13.3.0 * Deleted the e2e project, updated to project to adhere to strict typescript, removed all console.logs and removed all code that was commented out * chore: nx format:write update dirty files * Started implementing zod validation * chore: nx format:write update dirty files * Generated a nestjs client from our openapi schema * Generated a client and created a domain client for graphql * Update Form, Group, Input, and Step DTOs * Refactor input settings in FormsService and Input model * Update API and authentication configurations * Added form-system client and module to the app/api and added a codegen + script to generate graphql schemas * Remove form-system module and add formSystemNavigation to masterNavigation * Refactor form-system API code and formBuilder into portals/admin * Fixng typing erros in form system graphql domain * Added another Object type and a bunch of inputTypes in order for codegen to work * Update import statements for LanguageTypeInput * Update form system module and related files * Update FormSystemClient.config and Forms component * Saving progress * Working version. Current issue: inputsettings are not being saved due to graphql not handling type discriminators * took out the formsysteminputsettings and replaced it with a graphqlTypeJson * spring cleaning and creating dependencies within the form * removed form-builder app * chore: charts update dirty files * chore: nx format:write update dirty files * form-system backend initial commit * initial configuration * adjust for PR * fix lint warnings * add models and modules * helstu módel, services og controllerar * make lint satisfied * Add functionality to create and edit custom lists * application part start * change step to section and group to page * tiny lint things * change naming of page to screen * changed naming of input to field * fix lint warnings * change naming of input to field * work on application part * change tablenames to singular * changed naming of testimony to certification * fixing apiproperty configurations * changed naming of urlName to slug * introduce lodash pick * refactor vegna PR * add openapi.yaml build * Refactor project setup * Add class validation for CreateFormDto * add class-validation * use predefined types for cases in switch * Fix build * Fix lint * Update tags * Remove empty test files * Skip tests until implemented * Add advania as codeowner for new service * add infra definition * add the service to uber-charts * chore: charts update dirty files * update grantNamespaces * chore: charts update dirty files * added seed instruction to DLS * chore: charts update dirty files --------- Co-authored-by: Hyo-Sam Nandkisore <[email protected]> Co-authored-by: andes-it <[email protected]> Co-authored-by: Sævar Már Atlason <[email protected]> Co-authored-by: Bæring Gunnar Steinþórsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
...
What
Add functionality to the backend to create and edit custom lists
Checklist: