Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(endorsement-system): Test suite overhaul #16468

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rafnarnason
Copy link
Member

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@rafnarnason rafnarnason changed the title basic e2e dump and new setup feat(endorsement-system): Test suite overhaul Oct 18, 2024
@datadog-island-is
Copy link

datadog-island-is bot commented Oct 18, 2024

Datadog Report

All test runs 9fbfad3 🔗

4 Total Test Services: 0 Failed, 4 Passed
🔻 Test Sessions change in coverage: 1 decreased (-20.39%), 5 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 3.2s 1 no change Link
application-system-api 0 0 0 120 2 3m 15.32s 1 no change Link
application-template-api-modules 0 0 0 123 0 2m 27.83s 1 no change Link
services-endorsements-api 0 0 0 5 0 21.62s 1 decreased (-20.39%) Link

🔻 Code Coverage Decreases vs Default Branch (1)

  • services-endorsements-api - jest 31.3% (-20.39%) - Details

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.62%. Comparing base (d6b0e01) to head (2023e2a).
Report is 50 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16468      +/-   ##
==========================================
- Coverage   36.78%   36.62%   -0.17%     
==========================================
  Files        6835     6831       -4     
  Lines      141418   141546     +128     
  Branches    40266    40373     +107     
==========================================
- Hits        52019    51836     -183     
- Misses      89399    89710     +311     
Flag Coverage Δ
api 3.37% <ø> (ø)
application-system-api 41.35% <ø> (-0.03%) ⬇️
application-template-api-modules 27.80% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 59 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b0e01...2023e2a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants