Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feats(grants): Grants plaza UI #16505

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

feats(grants): Grants plaza UI #16505

wants to merge 21 commits into from

Conversation

thorkellmani
Copy link
Member

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 23.10231% with 233 lines in your changes missing coverage. Please review.

Project coverage is 36.69%. Comparing base (26fb2c5) to head (e6397ce).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
...web/screens/Grants/SearchResults/SearchResults.tsx 0.00% 54 Missing ⚠️
libs/cms/src/lib/models/grant.model.ts 43.75% 36 Missing ⚠️
apps/web/components/Plaza/Card/Card.tsx 0.00% 31 Missing ⚠️
apps/web/screens/Grants/Home/GrantsHome.tsx 0.00% 25 Missing ⚠️
...ibs/cms/src/lib/search/importers/grants.service.ts 25.00% 18 Missing ⚠️
libs/cms/src/lib/cms.contentful.service.ts 5.55% 17 Missing ⚠️
libs/cms/src/lib/cms.elasticsearch.service.ts 0.00% 13 Missing ⚠️
...mponents/Grant/HeaderWithImage/HeaderWithImage.tsx 0.00% 8 Missing ⚠️
libs/cms/src/lib/cms.resolver.ts 57.89% 8 Missing ⚠️
apps/web/components/Grant/Wrapper/GrantWrapper.tsx 0.00% 7 Missing ⚠️
... and 11 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16505      +/-   ##
==========================================
- Coverage   36.73%   36.69%   -0.04%     
==========================================
  Files        6809     6864      +55     
  Lines      141088   142347    +1259     
  Branches    40225    40683     +458     
==========================================
+ Hits        51826    52240     +414     
- Misses      89262    90107     +845     
Flag Coverage Δ
air-discount-scheme-backend 54.08% <ø> (+0.02%) ⬆️
air-discount-scheme-web 0.00% <ø> (ø)
api 3.37% <ø> (ø)
api-domains-air-discount-scheme 36.93% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.48% <ø> (ø)
api-domains-communications 39.88% <38.88%> (-0.01%) ⬇️
api-domains-criminal-record 48.00% <ø> (ø)
api-domains-driving-license 44.48% <ø> (+0.07%) ⬆️
api-domains-education 31.58% <ø> (+0.06%) ⬆️
api-domains-health-insurance 34.77% <ø> (ø)
api-domains-mortgage-certificate 34.95% <ø> (ø)
api-domains-payment-schedule 41.16% <ø> (ø)
application-api-files 56.86% <ø> (-1.16%) ⬇️
application-core 71.32% <ø> (-0.21%) ⬇️
application-system-api 41.35% <42.16%> (-0.08%) ⬇️
application-template-api-modules 27.85% <38.88%> (-0.03%) ⬇️
application-templates-accident-notification 29.27% <ø> (-0.03%) ⬇️
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.34% <ø> (-0.02%) ⬇️
application-templates-driving-license 18.34% <ø> (+0.05%) ⬆️
application-templates-estate 12.32% <ø> (+0.01%) ⬆️
application-templates-example-payment 25.14% <ø> (-0.01%) ⬇️
application-templates-financial-aid 15.50% <ø> (+1.22%) ⬆️
application-templates-general-petition 23.44% <ø> (+0.01%) ⬆️
application-templates-inheritance-report 6.49% <ø> (+0.05%) ⬆️
application-templates-marriage-conditions 15.17% <ø> (+0.08%) ⬆️
application-templates-mortgage-certificate 43.85% <100.00%> (+0.06%) ⬆️
application-templates-parental-leave 29.96% <ø> (-0.01%) ⬇️
application-types 6.63% <ø> (-0.07%) ⬇️
application-ui-components 1.28% <ø> (ø)
application-ui-shell 21.36% <ø> (+0.01%) ⬆️
auth-nest-tools 30.02% <100.00%> (+0.18%) ⬆️
auth-react 22.77% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
clients-driving-license 40.67% <ø> (ø)
clients-driving-license-book 43.80% <ø> (ø)
clients-financial-statements-inao 49.32% <ø> (ø)
clients-license-client 1.83% <ø> (ø)
clients-middlewares 72.86% <100.00%> (+0.15%) ⬆️
clients-regulations 42.80% <ø> (ø)
clients-rsk-company-registry 29.76% <ø> (ø)
clients-syslumenn 49.44% <ø> (ø)
cms 0.41% <0.00%> (-0.01%) ⬇️
cms-translations 39.03% <38.88%> (+0.01%) ⬆️
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.16% <ø> (ø)
contentful-apps 5.44% <ø> (-0.14%) ⬇️
download-service 44.22% <ø> (+0.03%) ⬆️
financial-aid-backend 56.37% <ø> (-0.04%) ⬇️
financial-aid-shared 18.94% <ø> (-0.09%) ⬇️
icelandic-names-registry-backend 53.97% <ø> (ø)
island-ui-core 28.39% <ø> (ø)
judicial-system-api 18.40% <ø> (+<0.01%) ⬆️
judicial-system-backend 54.93% <42.16%> (-0.26%) ⬇️
judicial-system-web 27.92% <ø> (-0.02%) ⬇️
license-api 42.53% <ø> (-0.22%) ⬇️
localization 10.15% <ø> (ø)
nest-audit 68.20% <ø> (ø)
nest-core 43.54% <ø> (?)
nest-feature-flags 51.52% <ø> (ø)
nest-problem 45.85% <ø> (ø)
nest-swagger 51.71% <ø> (ø)
portals-admin-regulations-admin 1.85% <ø> (ø)
portals-core 16.15% <ø> (ø)
reference-backend 49.79% <ø> (ø)
services-auth-admin-api 51.93% <100.00%> (+0.04%) ⬆️
services-auth-delegation-api 57.30% <100.00%> (-0.02%) ⬇️
services-auth-ids-api 51.42% <100.00%> (-0.01%) ⬇️
services-auth-personal-representative 45.10% <100.00%> (-0.06%) ⬇️
services-auth-personal-representative-public 41.27% <100.00%> (+0.03%) ⬆️
services-endorsements-api 53.66% <ø> (-0.54%) ⬇️
services-sessions 65.39% <100.00%> (+0.01%) ⬆️
services-university-gateway 48.28% <ø> (-0.03%) ⬇️
services-user-notification 46.83% <42.16%> (-0.18%) ⬇️
services-user-profile 61.75% <ø> (-0.36%) ⬇️
shared-components 27.65% <ø> (ø)
shared-form-fields 31.60% <ø> (+0.01%) ⬆️
shared-problem 87.50% <ø> (ø)
shared-utils 27.69% <ø> (-0.22%) ⬇️
skilavottord-ws 24.24% <ø> (ø)
web 1.79% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/web/hooks/useLinkResolver/useLinkResolver.ts 72.13% <ø> (ø)
libs/cms/src/lib/search/cmsSync.module.ts 100.00% <100.00%> (ø)
libs/cms/src/lib/search/mapping.service.ts 91.22% <100.00%> (+0.31%) ⬆️
libs/shared/types/src/lib/api-cms-domain.ts 100.00% <100.00%> (ø)
apps/web/components/Grant/HeaderWithImage/index.ts 0.00% <0.00%> (ø)
apps/web/components/Grant/SearchSection/index.tsx 0.00% <0.00%> (ø)
apps/web/screens/Grants/messages.ts 0.00% <0.00%> (ø)
apps/web/screens/queries/GenericTag.ts 0.00% <0.00%> (ø)
apps/web/screens/queries/Grants.ts 0.00% <0.00%> (ø)
libs/cms/src/lib/dto/getGrants.input.ts 90.00% <90.00%> (ø)
... and 15 more

... and 306 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26fb2c5...e6397ce. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Oct 22, 2024

Datadog Report

All test runs bafefa4 🔗

81 Total Test Services: 0 Failed, 78 Passed
🔻 Test Sessions change in coverage: 6 decreased, 8 increased, 186 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 81 0 32.08s N/A Link
air-discount-scheme-web 0 0 0 2 0 9.13s N/A Link
api 0 0 0 4 0 3.65s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 22.28s N/A Link
api-domains-assets 0 0 0 3 0 13.53s N/A Link
api-domains-auth-admin 0 0 0 18 0 14.62s N/A Link
api-domains-communications 0 0 0 5 0 35.13s 1 increased (+0.01%) Link
api-domains-criminal-record 0 0 0 5 0 11.3s N/A Link
api-domains-driving-license 0 0 0 23 0 37.21s 1 no change Link
api-domains-education 0 0 0 8 0 23.81s N/A Link

🔻 Code Coverage Decreases vs Default Branch (6)

This report shows up to 5 code coverage decreases.

  • clients-middlewares - jest 75.6% (-0.17%) - Details
  • judicial-system-backend - jest 58.43% (-0.07%) - Details
  • services-user-profile - jest 52.52% (-0.04%) - Details
  • web - jest 2.49% (-0.02%) - Details
  • services-university-gateway - jest 44.84% (-0.02%) - Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants