Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(financial-aid): dynamic logo #16523

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jonnigs
Copy link
Member

@jonnigs jonnigs commented Oct 22, 2024

What

Fix error in dynamic log when prereq fails

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@jonnigs jonnigs requested a review from a team as a code owner October 22, 2024 17:02
@jonnigs jonnigs changed the title fix: logo fix(financial-aid): dynamic logo Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.77%. Comparing base (38da8d3) to head (7aa495d).
Report is 1 commits behind head on pre-release/32.2.0.

Files with missing lines Patch % Lines
...mplates/financial-aid/src/components/Logo/Logo.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           pre-release/32.2.0   #16523      +/-   ##
======================================================
- Coverage               36.77%   36.77%   -0.01%     
======================================================
  Files                    6847     6847              
  Lines                  141870   141872       +2     
  Branches                40421    40423       +2     
======================================================
  Hits                    52167    52167              
- Misses                  89703    89705       +2     
Flag Coverage Δ
api 3.37% <ø> (ø)
application-system-api 41.34% <ø> (ø)
application-template-api-modules 27.81% <ø> (ø)
application-templates-financial-aid 15.49% <0.00%> (-0.02%) ⬇️
application-ui-shell 21.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mplates/financial-aid/src/components/Logo/Logo.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38da8d3...7aa495d. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs fe762ab 🔗

5 Total Test Services: 0 Failed, 5 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.01%), 7 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.98s 1 no change Link
application-system-api 0 0 0 120 2 3m 27.16s 1 no change Link
application-template-api-modules 0 0 0 123 0 2m 42.42s 1 no change Link
application-templates-financial-aid 0 0 0 11 0 16.24s 1 decreased (-0.01%) Link
application-ui-shell 0 0 0 74 0 35.95s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (1)

  • application-templates-financial-aid - jest 19.84% (-0.01%) - Details

@jonnigs jonnigs added the automerge Merge this PR as soon as all checks pass label Oct 23, 2024
@kodiakhq kodiakhq bot merged commit 4402e3b into pre-release/32.2.0 Oct 23, 2024
88 of 111 checks passed
@kodiakhq kodiakhq bot deleted the fix/dynamic-logo-financial-aid branch October 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants