Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added winston to infra package.json #16530

Closed
wants to merge 2 commits into from
Closed

Conversation

busla
Copy link
Member

@busla busla commented Oct 23, 2024

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@busla busla requested a review from a team as a code owner October 23, 2024 12:19
@busla busla removed the request for review from a team October 23, 2024 12:19
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.77%. Comparing base (1395ef8) to head (e84bb6b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           feat/bff   #16530      +/-   ##
============================================
+ Coverage     36.73%   36.77%   +0.03%     
============================================
  Files          6860     6850      -10     
  Lines        142080   141714     -366     
  Branches      40528    40402     -126     
============================================
- Hits          52199    52112      -87     
+ Misses        89881    89602     -279     
Flag Coverage Δ
air-discount-scheme-backend 54.22% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.37% <ø> (ø)
api-catalogue-services 77.85% <ø> (ø)
api-domains-air-discount-scheme 37.30% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.48% <ø> (ø)
api-domains-communications 39.91% <ø> (ø)
api-domains-criminal-record 47.83% <ø> (ø)
api-domains-driving-license 44.56% <ø> (-0.05%) ⬇️
api-domains-education 31.58% <ø> (ø)
api-domains-health-insurance 34.77% <ø> (ø)
api-domains-mortgage-certificate 34.90% <ø> (ø)
api-domains-payment-schedule 41.51% <ø> (ø)
application-api-files 56.86% <ø> (ø)
application-core 71.64% <ø> (ø)
application-system-api 41.38% <ø> (+0.01%) ⬆️
application-template-api-modules 27.86% <ø> (+0.03%) ⬆️
application-templates-accident-notification 29.27% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.34% <ø> (ø)
application-templates-driving-license 18.32% <ø> (-0.02%) ⬇️
application-templates-estate 12.26% <ø> (+<0.01%) ⬆️
application-templates-example-payment 25.14% <ø> (ø)
application-templates-financial-aid 15.58% <ø> (+0.01%) ⬆️
application-templates-general-petition 23.44% <ø> (ø)
application-templates-inheritance-report 6.49% <ø> (ø)
application-templates-marriage-conditions 15.17% <ø> (ø)
application-templates-mortgage-certificate 43.85% <ø> (ø)
application-templates-parental-leave 29.96% <ø> (-0.08%) ⬇️
application-types 6.63% <ø> (ø)
application-ui-components 1.28% <ø> (ø)
application-ui-shell 21.01% <ø> (+<0.01%) ⬆️
auth-admin-web 2.43% <ø> (ø)
auth-nest-tools 30.02% <ø> (ø)
auth-react 22.44% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
clients-driving-license 40.56% <ø> (ø)
clients-driving-license-book 43.70% <ø> (ø)
clients-financial-statements-inao 49.32% <ø> (ø)
clients-license-client 1.83% <ø> (ø)
clients-middlewares 73.45% <ø> (+0.25%) ⬆️
clients-regulations 42.66% <ø> (ø)
clients-rsk-company-registry 29.76% <ø> (ø)
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.34% <ø> (ø)
clients-zendesk 54.61% <ø> (ø)
cms 0.42% <ø> (ø)
cms-translations 39.04% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.16% <ø> (ø)
contentful-apps 5.44% <ø> (ø)
dokobit-signing 63.38% <ø> (ø)
download-service 44.39% <ø> (ø)
email-service 61.13% <ø> (ø)
feature-flags 91.11% <ø> (ø)
file-storage 53.71% <ø> (ø)
financial-aid-backend 56.52% <ø> (+0.11%) ⬆️
financial-aid-shared 18.94% <ø> (ø)
icelandic-names-registry-backend 54.34% <ø> (ø)
infra-nest-server 48.37% <ø> (ø)
infra-tracing 43.24% <ø> (ø)
island-ui-core 28.39% <ø> (ø)
judicial-system-api 18.36% <ø> (-0.07%) ⬇️
judicial-system-audit-trail 69.35% <ø> (ø)
judicial-system-formatters 79.25% <ø> (ø)
judicial-system-message 67.24% <ø> (ø)
judicial-system-message-handler 48.35% <ø> (ø)
judicial-system-scheduler 69.54% <ø> (ø)
judicial-system-types 47.12% <ø> (ø)
judicial-system-web 27.91% <ø> (+<0.01%) ⬆️
license-api 42.89% <ø> (+0.16%) ⬆️
localization 10.15% <ø> (ø)
logging 48.43% <ø> (ø)
message-queue 68.58% <ø> (ø)
nest-audit 68.20% <ø> (ø)
nest-aws 60.29% <ø> (ø)
nest-config 78.44% <ø> (ø)
nest-feature-flags 51.52% <ø> (-0.51%) ⬇️
nest-problem 45.82% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 51.71% <ø> (ø)
nova-sms 62.74% <ø> (ø)
portals-admin-regulations-admin 1.86% <ø> (ø)
portals-core 16.04% <ø> (ø)
reference-backend 49.74% <ø> (ø)
regulations 16.78% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-admin-api 51.95% <ø> (ø)
services-auth-delegation-api 57.34% <ø> (ø)
services-auth-ids-api 51.47% <ø> (-0.01%) ⬇️
services-auth-personal-representative 45.17% <ø> (+<0.01%) ⬆️
services-auth-personal-representative-public 41.34% <ø> (+<0.01%) ⬆️
services-auth-public-api 48.96% <ø> (ø)
services-documents 60.81% <ø> (ø)
services-endorsements-api 53.79% <ø> (ø)
services-sessions 65.47% <ø> (ø)
services-university-gateway 48.27% <ø> (-0.03%) ⬇️
services-user-notification 47.07% <ø> (+0.08%) ⬆️
services-user-profile 62.28% <ø> (+0.44%) ⬆️
shared-components 27.06% <ø> (ø)
shared-form-fields 31.59% <ø> (-0.02%) ⬇️
shared-mocking 60.89% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 27.69% <ø> (ø)
skilavottord-ws 24.24% <ø> (ø)
testing-e2e 66.66% <ø> (ø)
web 1.82% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 85 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1395ef8...e84bb6b. Read the comment docs.

@busla busla changed the title deps: added winston to infra package.json chore: added winston to infra package.json Oct 23, 2024
@datadog-island-is
Copy link

Datadog Report

All test runs 484b702 🔗

100 Total Test Services: 0 Failed, 97 Passed
🔻 Test Sessions change in coverage: 16 decreased, 24 increased, 158 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 81 0 34.75s N/A Link
air-discount-scheme-web 0 0 0 2 0 9.52s N/A Link
api 0 0 0 4 0 2.83s N/A Link
api-catalogue-services 0 0 0 23 0 11.46s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 24.32s N/A Link
api-domains-assets 0 0 0 3 0 14.68s N/A Link
api-domains-auth-admin 0 0 0 18 0 15.03s N/A Link
api-domains-communications 0 0 0 5 0 35.14s N/A Link
api-domains-criminal-record 0 0 0 5 0 10.83s N/A Link
api-domains-driving-license 0 0 0 23 0 31.77s N/A Link

🔻 Code Coverage Decreases vs Default Branch (16)

This report shows up to 5 code coverage decreases.

  • nest-core - jest 0% (-48.21%) - Details
  • react-spa-shared - jest 15.62% (-8.97%) - Details
  • shared-mocking - jest 58.86% (-4.01%) - Details
  • shared-components - jest 33.41% (-1.37%) - Details
  • portals-core - jest 23.93% (-0.77%) - Details

@busla busla closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant