Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Stepper on subarticles #16541

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RunarVestmann
Copy link
Member

Stepper on subarticles

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 36.76%. Comparing base (4919948) to head (34c5044).

Files with missing lines Patch % Lines
apps/web/screens/Article/Article.tsx 0.00% 27 Missing ⚠️
libs/cms/src/lib/models/subArticle.model.ts 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16541      +/-   ##
==========================================
- Coverage   36.76%   36.76%   -0.01%     
==========================================
  Files        6851     6851              
  Lines      142120   142135      +15     
  Branches    40542    40546       +4     
==========================================
+ Hits        52250    52252       +2     
- Misses      89870    89883      +13     
Flag Coverage Δ
air-discount-scheme-web 0.00% <ø> (ø)
api 3.37% <ø> (ø)
api-domains-auth-admin 48.48% <ø> (ø)
api-domains-communications 39.90% <50.00%> (+<0.01%) ⬆️
application-api-files 56.76% <ø> (ø)
application-core 71.32% <ø> (-0.33%) ⬇️
application-system-api 41.37% <50.00%> (+<0.01%) ⬆️
application-template-api-modules 27.82% <50.00%> (+0.01%) ⬆️
application-templates-accident-notification 29.27% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.34% <ø> (ø)
application-templates-driving-license 18.34% <ø> (ø)
application-templates-estate 12.31% <ø> (ø)
application-templates-example-payment 25.14% <ø> (ø)
application-templates-financial-aid 15.49% <ø> (ø)
application-templates-general-petition 23.44% <ø> (ø)
application-templates-inheritance-report 6.49% <ø> (ø)
application-templates-marriage-conditions 15.17% <ø> (ø)
application-templates-mortgage-certificate 43.56% <ø> (ø)
application-templates-parental-leave 29.96% <ø> (ø)
application-types 6.63% <ø> (ø)
application-ui-components 1.28% <ø> (ø)
application-ui-shell 21.36% <ø> (ø)
auth-react 22.81% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
cms 0.42% <0.00%> (-0.01%) ⬇️
cms-translations 39.03% <50.00%> (+<0.01%) ⬆️
contentful-apps 5.44% <ø> (ø)
financial-aid-backend 56.25% <ø> (ø)
financial-aid-shared 18.94% <ø> (ø)
island-ui-core 28.44% <ø> (ø)
judicial-system-api 18.36% <ø> (ø)
judicial-system-backend 55.16% <50.00%> (-0.01%) ⬇️
judicial-system-web 27.81% <ø> (ø)
portals-admin-regulations-admin 1.85% <ø> (ø)
portals-core 16.14% <ø> (ø)
services-auth-personal-representative 45.11% <ø> (-0.04%) ⬇️
services-user-notification 46.90% <50.00%> (-0.03%) ⬇️
shared-components 27.70% <ø> (ø)
shared-form-fields 31.57% <ø> (ø)
web 1.80% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/web/screens/queries/Article.ts 0.00% <ø> (ø)
...island-ui/core/src/lib/Breadcrumbs/Breadcrumbs.tsx 100.00% <ø> (ø)
libs/cms/src/lib/models/subArticle.model.ts 47.05% <50.00%> (+0.39%) ⬆️
apps/web/screens/Article/Article.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4919948...34c5044. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs 6e7bed7 🔗

41 Total Test Services: 0 Failed, 38 Passed
🔻 Test Sessions change in coverage: 3 decreased, 167 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-web 0 0 0 2 0 9.19s 1 no change Link
api 0 0 0 4 0 3.09s 1 no change Link
api-domains-auth-admin 0 0 0 18 0 14.71s 1 no change Link
api-domains-communications 0 0 0 5 0 34.88s 1 no change Link
api-domains-license-service 0 0 0 0 0 535.16ms 1 no change Link
application-api-files 0 0 0 12 0 6.47s 1 no change Link
application-core 0 0 0 92 0 20.26s 1 decreased (-0.2%) Link
application-system-api 0 0 0 120 2 3m 45.51s 1 no change Link
application-template-api-modules 0 0 0 123 0 2m 39.61s 1 no change Link
application-templates-accident-notification 0 0 0 148 0 21.46s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (3)

  • application-core - jest 79.37% (-0.2%) - Details
  • services-auth-personal-representative - jest 44% (-0.02%) - Details
  • services-user-notification - jest 69.58% (-0.01%) - Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant