Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CppCoreGuidelines.md #2217

Closed
wants to merge 1 commit into from
Closed

Update CppCoreGuidelines.md #2217

wants to merge 1 commit into from

Conversation

Aster89
Copy link

@Aster89 Aster89 commented Sep 10, 2024

Addressing the issue #2205 I opened myself.

I can't see why not contributing with this addition.

Addressing the issue isocpp#2205 I opened myself.

I can't see why not contributing.
use `()` to avoid erroneously constructing a nested container:

vector<any> v{1,2,3};
vector<any> u{v}; // most likely unintended: u has 1 element of type any, which contains v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel u{v}; // most likely unintended: u has 1 element contradicts v2{10}; // vector of 1 element with the value 10 a few lines above; constructing a 1-element vector holding v as its element is what curlies show the intent of.

Copy link
Author

@Aster89 Aster89 Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "title" of the guidline is Prefer the {}-initializer syntax, which per se does not refer to initializer lists nor anything else that is discussed in the various examples.

The same holds for the Reason paragraph.

I think that's enough for the reader to interpret the guildeline as "Ok, I'll blindly use {} for initializing anything until I get some compile-time or run-time error".

Furthermore, the example you mention is constrasting list of elements vs size for containers, whereas the case I'm making is about list of elements vs copy, and the whole item does not make any mention as regards preferring {} vs () for copy constructing an entity, so in the absernce of an explicit mention of that, I think it's legit that the reader assumes that they should prefer {}, following the title of the guideline.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editors call: Thanks!

I think that's enough for the reader to interpret the guildeline as "Ok, I'll blindly use {} for initializing anything until I get some compile-time or run-time error".

The guideline starts with "Prefer" so we think that it doesn't say to blindly use braces. Also, any is a good example but a very special outlier type; vector<int> x(1, 2) is the stronger example and we think is covered in the first Exception. So we don't think a change is needed.

@hsutter hsutter self-assigned this Sep 26, 2024
@hsutter hsutter closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants