Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for mac arm and brew #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dioptre
Copy link

@dioptre dioptre commented Aug 7, 2024

No description provided.

@isohedral
Copy link
Owner

isohedral commented Aug 8, 2024

Thanks for the proposed PR. Most of the changes are generally OK, but I have a couple of concerns.

  • I would prefer for the licenses not to include your name as the copyright holder.
  • I still use Macports, not homebrew, so it would be good if the code could be built on top of either. The canonical solution would be a smarter build system, e.g., cmake. But I don't have the time or expertise to create that. A compromise would be multiple different makefiles.
  • I don't know where your images came from, and need to know that I have permission to include them.
  • I don't see any changes to the source code (what was updated for "mac arm"?).

@dioptre
Copy link
Author

dioptre commented Aug 8, 2024

Ok no worries, we can leave this here for people using brew.
1 & 3. the images come from a site https://opengameart.org/textures/all that requires one of them to be cc-by-..... and the license is from that
2. i was just trying to get it going - so might leave that there
3. mac arm is supported by brew and x86 - i was thinking it was broken due to an x86 thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants