Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows customization of icons #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeroenheijmans
Copy link

Fixes #245 in original repository.

After this change the user can fully customize the "icons", replacing
the default html entity characters by any string, including:

  • Different html entities or unicode characters;
  • Bits of html offloading things to a icon font;
  • Html img tags;
  • Empty strings (that effectively removes the icons);

The change is backwards compatible, only "activated" if the element that
uses this directive also has a custom-icon attribute. That attribute
works analogous to the translation attribute. Backwards compatability
is the reason for the somewhat convoluted "pad-with-nbsp" function, that
might be removed in a future major release.

Fixes isteven#245 in original repository.

After this change the user can fully customize the "icons", replacing
the default html entity characters by any string, including:

- Different html entities or unicode characters;
- Bits of html offloading things to a icon font;
- Html img tags;
- Empty strings (that effectively removes the icons);

The change is backwards compatible, only "activated" if the element that
uses this directive also has a `custom-icon` attribute. That attribute
works analogous to the `translation` attribute. Backwards compatability
is the reason for the somewhat convoluted "pad-with-nbsp" function, that
might be removed in a future major release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant