Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-6019 : Make ingress gateway selection consistent. #376

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

virajrk
Copy link
Collaborator

@virajrk virajrk commented Jan 8, 2025

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

Currently admiral load ingress gateway via two point and two different selector getting used.

  • Name of Kubernetes service
  • Label selector

Moving this only label selector.

Thank you!

Viraj Kulkarni added 5 commits January 8, 2025 09:37
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
Signed-off-by: Viraj Kulkarni <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.57%. Comparing base (e885c76) to head (4c497b6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
admiral/pkg/controller/common/common.go 0.00% 5 Missing ⚠️
admiral/pkg/clusters/service_handler.go 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   76.76%   76.57%   -0.19%     
==========================================
  Files          75       75              
  Lines       10300    10303       +3     
==========================================
- Hits         7907     7890      -17     
- Misses       1988     2004      +16     
- Partials      405      409       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants