Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix additional broken in-doc header links #15640

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

kfaseela
Copy link
Member

@kfaseela kfaseela commented Sep 3, 2024

Description

Part of #15624

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@kfaseela kfaseela requested review from a team as code owners September 3, 2024 08:54
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 3, 2024
@kfaseela
Copy link
Member Author

kfaseela commented Sep 3, 2024

cc @jaellio

@kfaseela kfaseela added the cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch label Sep 3, 2024
Signed-off-by: Faseela K <[email protected]>
Signed-off-by: Faseela K <[email protected]>
@kfaseela
Copy link
Member Author

kfaseela commented Sep 3, 2024

Cc @wilsonwu

@istio-testing istio-testing merged commit 7c2892d into istio:master Sep 4, 2024
6 checks passed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #15644

@wilsonwu
Copy link
Member

wilsonwu commented Sep 4, 2024

Cc @wilsonwu

Sorry for replay late, the links only update is all fine, but lots of Chinese content out of date, maybe cherry pick will blocked, there is an issue #15567, let's get a chance to make it up to date.

@jaellio
Copy link
Contributor

jaellio commented Sep 9, 2024

@kfaseela Thanks for making the fix!!

@kfaseela kfaseela deleted the in-doc-header-links-broken branch September 12, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch kind/docs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants