Add support for OpenSSL #1436
Add support for OpenSSL #1436
Conversation
istio-testing
added
the
do-not-merge/work-in-progress
|
😊 Welcome @tedjpoole! This is either your first contribution to the Istio ztunnel repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
size/L
|
Hi @tedjpoole. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
FYI if you haven't seen this: #1323 (comment). Looks like you followed all the suggestions there already though!
src/tls/lib.rs
Outdated
| @@ -66,6 +66,19 @@ pub(super) fn provider() -> Arc<CryptoProvider> { | |||
| }) | |||
| } | |||
|
|
|||
| #[cfg(feature = "tls-openssl")] | |||
| pub(super) fn provider() -> Arc<CryptoProvider> { | |||
| // Arc::new(rustls_openssl::default_provider()) | |||
Signed-off-by: Ted Poole <[email protected]>
tedjpoole
force-pushed
the
add-tls-openssl-feature
branch
from
775baab to
252f024
Compare
istio-testing
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
istio-testing
added
ok-to-test
|
@tedjpoole: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add support for using OpenSSL as an alternative crypto provider, implemented using the rustls-openssl and openssl crates, and guarded by a new feature called
tls-openssl.fixes #149