Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errgroup全部消す #385

Merged
merged 5 commits into from
Nov 24, 2023
Merged

errgroup全部消す #385

merged 5 commits into from
Nov 24, 2023

Conversation

fujiwara
Copy link
Member

  • grpだけど1個しかない(使う必要がない)もの
  • お互いのシナリオのエラーで相互に影響されたくないもの

errgroupを全てなくしました
viewerシナリオはReportを分割しました

- grpだけど1個しかない(使う必要がない)もの
- お互いのシナリオのエラーで相互に影響されたくないもの

errgroupを全てなくしました
viewerシナリオはReportを分割しました
@fujiwara fujiwara requested a review from tukeJonny November 24, 2023 02:22
Copy link
Contributor

@tukeJonny tukeJonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

イメージ通りの改修なので、LGTMです 🙇
(pretestでもerrgroupを使っていた・・・)

@fujiwara fujiwara merged commit 474d86d into main Nov 24, 2023
7 checks passed
@fujiwara fujiwara deleted the fix/no-errgroup branch November 24, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants