Change user methods to work with authorId #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 23, 2023 20:28
… userEntity from authorEntity, change some dtos
handicraftsman
requested changes
Nov 1, 2023
| @@ -112,31 +118,76 @@ public UserDTO findExpertById(Integer userId) { | |||
| public Page<UserDTO> findAllExperts(UserSearchCriteria userSearchCriteria, Pageable pageable) { | |||
|
|
|||
| if (validateParameters(userSearchCriteria, HAS_NO_DIRECTIONS, HAS_NO_REGIONS, HAS_NO_USERNAME)) { | |||
| return userRepository.findAll(pageable).map(userMapper::toUserDTO); | |||
| Page<UserDTO> userDTOS = userRepository.findAll(pageable).map(userMapper::toUserDTO); | |||
| List<AuthorEntity> authors = authorRepository.findAll(); | |||
There was a problem hiding this comment.
It would work initially, but ideally this should be done on the database (SQL) side.
Yes, it will probably be a somewhat big JOIN, but it will still be faster than fetching all the authors to only use some of them.
Additionally, you can do something like this:
@Query("SELECT ... FROM ... WHERE profileId IN (:userIds)") // Might need to do a JOIN here, I do not remember the database structure. That will still be faster though.
List<Author> getAuthorsByUserIds(Set<String> userIds);You should then convert the authors list to a map using Java streams.
Finding authors using that will be much faster than iterating through authors list again and again.
Same is for all the similar blocks below.
* Refactored deleteById method * Fixed style errors * Tests are ready to go * Refactored deleteById method * Fixed style errors * Tests are ready to go * Added eventPublisher for deleteById method * Added method to change status
… userEntity from authorEntity, change some dtos
handicraftsman
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Can be rewritten in a shorter way using mapstruct and JPA queries, but I suggested @VadimasikKPI doing that in a follow-up pull request after he reads more on mapstruct.
VadimasikKPI
added a commit
that referenced
this pull request
Nov 1, 2023
* Implement user account activation logic without tests, they will be in next commits * Return port 5432 to docker compose file * Made changes regarding comments * Made changes regarding comments * Delete rewrite (#616) * Refactored deleteById method * Fixed style errors * Tests are ready to go * Refactored deleteById method * Fixed style errors * Tests are ready to go * Added eventPublisher for deleteById method * Added method to change status * Change user methods to work with authorId (#617) * Change everywhere we use userId to AuthorId and then add logic to get userEntity from authorEntity, change some dtos * Change tests to new version of code * Change tests to new version of code * Change tests to new version of code * test * test * test * Delete rewrite (#616) * Refactored deleteById method * Fixed style errors * Tests are ready to go * Refactored deleteById method * Fixed style errors * Tests are ready to go * Added eventPublisher for deleteById method * Added method to change status * Change everywhere we use userId to AuthorId and then add logic to get userEntity from authorEntity, change some dtos * Change tests to new version of code * Change tests to new version of code * Change tests to new version of code * test * test * test * Add join author id to all queries that returns user information --------- Co-authored-by: VadimasikKPI <[email protected]> Co-authored-by: Voloshkevych <[email protected]> --------- Co-authored-by: VadimasikKPI <[email protected]> Co-authored-by: Voloshkevych <[email protected]>
VadimasikKPI
added a commit
that referenced
this pull request
Nov 17, 2023
* Update develop.md * Update master.md * Add dokazovi.info into allowed_origin * Merge 634 user story and delete logic (#618) * Implement user account activation logic without tests, they will be in next commits * Return port 5432 to docker compose file * Made changes regarding comments * Made changes regarding comments * Delete rewrite (#616) * Refactored deleteById method * Fixed style errors * Tests are ready to go * Refactored deleteById method * Fixed style errors * Tests are ready to go * Added eventPublisher for deleteById method * Added method to change status * Change user methods to work with authorId (#617) * Change everywhere we use userId to AuthorId and then add logic to get userEntity from authorEntity, change some dtos * Change tests to new version of code * Change tests to new version of code * Change tests to new version of code * test * test * test * Delete rewrite (#616) * Refactored deleteById method * Fixed style errors * Tests are ready to go * Refactored deleteById method * Fixed style errors * Tests are ready to go * Added eventPublisher for deleteById method * Added method to change status * Change everywhere we use userId to AuthorId and then add logic to get userEntity from authorEntity, change some dtos * Change tests to new version of code * Change tests to new version of code * Change tests to new version of code * test * test * test * Add join author id to all queries that returns user information --------- Co-authored-by: VadimasikKPI <[email protected]> Co-authored-by: Voloshkevych <[email protected]> --------- Co-authored-by: VadimasikKPI <[email protected]> Co-authored-by: Voloshkevych <[email protected]> * bug fixes * make changes according to coments * make changes according to coments --------- Co-authored-by: Vitalii Kulinskyi <[email protected]> Co-authored-by: AxelNordov <[email protected]> Co-authored-by: Stanislav Kucher <[email protected]> Co-authored-by: Ihor Zakharko <[email protected]> Co-authored-by: Vlad Kaidash <[email protected]> Co-authored-by: Anton Sidliar <[email protected]> Co-authored-by: Artem Kurovskyi <[email protected]> Co-authored-by: vasilpetrus <[email protected]> Co-authored-by: VadimasikKPI <[email protected]> Co-authored-by: Voloshkevych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
develop
GitHub Board
Issue link
#11 Issue name
Story link
#11 Story
Code reviewers
Summary of issue
Summary of change