Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a11y aggiunta labelWaria sui componenti Callout, Autocomplete e Stepper #322

Closed
wants to merge 6 commits into from

Conversation

carmelotaverniti
Copy link
Contributor

@carmelotaverniti carmelotaverniti commented Feb 9, 2024

fix: a11y Aggiunta labelWaria sui componenti Callout, Autocomplete e Stepper

Descrizione

Checklist

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-angular-kit ✅ Ready (Inspect) Visit Preview Feb 12, 2024 10:01pm

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (70895e4) 45.71% compared to head (6b12ee9) 45.77%.

Files Patch % Lines
...c/lib/components/core/callout/callout.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   45.71%   45.77%   +0.05%     
==========================================
  Files          70       70              
  Lines        1133     1136       +3     
  Branches      236      236              
==========================================
+ Hits          518      520       +2     
- Misses        590      591       +1     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carmelotaverniti carmelotaverniti changed the title Aggiunta labelWaria sui componenti Callout, Autocomplete e Stepper fix: a11y aggiunta labelWaria sui componenti Callout, Autocomplete e Stepper Feb 12, 2024
@astagi
Copy link
Member

astagi commented Feb 26, 2024

Grazie @carmelotaverniti mi sorge un attimo un dubbio: alcune aria label erano state messe come elementi dei file di traduzione, qui verrebbero proprio passati come attributo. Devo capire qual'è la miglior strada. Ti aggiorno.

@astagi
Copy link
Member

astagi commented Mar 7, 2024

Grazie @carmelotaverniti mi sorge un attimo un dubbio: alcune aria label erano state messe come elementi dei file di traduzione, qui verrebbero proprio passati come attributo. Devo capire qual'è la miglior strada. Ti aggiorno.

Riguardo a questo dubbio chiamo in causa @AntoninoBonanno

Copy link
Collaborator

@AntoninoBonanno AntoninoBonanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queste label le metterei nei file di traduzione e magari renderle più esplicite.

@astagi
Copy link
Member

astagi commented Mar 11, 2024

@carmelotaverniti pensi sia possibile per te migrare le label all'interno dei file di traduzione come fatto per le altre label?

@astagi
Copy link
Member

astagi commented Mar 16, 2024

@carmelotaverniti abbiamo spostato le modifiche su #339

@astagi
Copy link
Member

astagi commented Mar 18, 2024

@carmelotaverniti mergiata su main, grazie mille del contributo!

@astagi astagi closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants