Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#281 remove dependency with sd jwt python (#297) #306

Closed
wants to merge 24 commits into from
Closed

Feature/#281 remove dependency with sd jwt python (#297) #306

wants to merge 24 commits into from

Conversation

peppelinux
Copy link
Member

  • feat: removed sd-jwt external library dependency

  • feat: added tests

  • switch from jwcrypto to cryptojwt

  • feat: add documentation

  • fix: flat old layers

  • Update pyeudiw/sd_jwt/common.py

  • Update docs/SD-JWT.md

  • Update pyeudiw/openid4vp/authorization_response.py

  • Update pyeudiw/sd_jwt/holder.py

  • fix: old types and continue flatting

  • fix: removing translation layer for jwcrypto library

  • wip: issues are confined on sd_jwt folder

  • wip: holder fixed

  • wip: json serialization format management

LadyCodesItBetter and others added 2 commits November 14, 2024 16:17
@LadyCodesItBetter @peppelinux
Feature/#281 remove dependency with sd jwt python (#297)
335bece 
* feat: removed sd-jwt external library dependency

* feat: added tests

* switch from jwcrypto to cryptojwt

* feat: add documentation

* fix: flat old layers

* Update pyeudiw/sd_jwt/common.py

Co-authored-by: Giuseppe De Marco <[email protected]>

* Update docs/SD-JWT.md

Co-authored-by: Giuseppe De Marco <[email protected]>

* Update pyeudiw/openid4vp/authorization_response.py

Co-authored-by: Giuseppe De Marco <[email protected]>

* Update pyeudiw/sd_jwt/holder.py

Co-authored-by: Giuseppe De Marco <[email protected]>

* fix: old types and continue flatting

* fix: removing translation layer for jwcrypto library

* wip: issues are confined on sd_jwt folder

* wip: holder fixed

* wip: json serialization format management

---------

Co-authored-by: Giuseppe De Marco <[email protected]>
@peppelinux
fix: CI and code alignemnt [wip]
6bcfaa3
peppelinux
peppelinux commented Nov 14, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 14, 2024
View reviewed changes
pyeudiw/sd_jwt/__init__.py Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content of this file must be restored in a file utils.py, used by integration tests, see whihc dependency is required by

examples/satosa/ integration tests

@LadyCodesItBetter LadyCodesItBetter mentioned this pull request Nov 15, 2024
Merged
peppelinux
peppelinux commented Nov 19, 2024
View reviewed changes
pyeudiw/sd_jwt/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux and others added 12 commits November 19, 2024 15:26
@peppelinux
Apply suggestions from code review
1ea832a
@LadyCodesItBetter
fix: all reference for sym key removed
34c27fc
@LadyCodesItBetter
feat: add license, documentation and fork disclaimer
e02393b
@LadyCodesItBetter
feat: dynamic MongoDB config via PYEUDIW_MONGO_TEST_AUTH_INLINE
8431fa8 
- Replaced hardcoded MongoDB credentials with dynamic env variable.
- Added fallback to 'satosa:thatpassword' for unauthenticated setups.
- Updated config to parse username/password inline.
- Documented usage and default behavior.
@LadyCodesItBetter
fix: some reference of unused key type
47def07
@LadyCodesItBetter
fix: old methods references
01057d9
@LadyCodesItBetter
fix: wrong connection string
daa9d74
@LadyCodesItBetter
fix: last tests kid issue and removed old test in order to use the ne…
07d2e87 
…ws tests from library repo
@LadyCodesItBetter
feat: added logger
37c39ba
@LadyCodesItBetter
feat: unprotected header management and claims on headers
8bbc0a0
@LadyCodesItBetter
feat: added json serialization format verifier
16df309
@LadyCodesItBetter
feat: empty authentication settings for tests can be set with custom …
16cea56 
…auth settings using PYEUDIW_MONGO_TEST_AUTH_INLINE env
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
docs/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
pyeudiw/jwt/__init__.py Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
pyeudiw/jwt/__init__.py Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
pyeudiw/sd_jwt/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
pyeudiw/sd_jwt/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
pyeudiw/sd_jwt/SD-JWT.md Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 21, 2024
View reviewed changes
pyeudiw/jwt/__init__.py Outdated Show resolved Hide resolved
@peppelinux
Copy link
Member Author

Merged in #305

@peppelinux peppelinux closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadyCodesItBetter LadyCodesItBetter LadyCodesItBetter left review comments

Assignees

@LadyCodesItBetter LadyCodesItBetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppelinux @LadyCodesItBetter