Pas merge #315
Merged
Pas merge #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zicchio
reviewed
Dec 18, 2024
Zicchio
reviewed
Dec 18, 2024
| @@ -0,0 +1,208 @@ | |||
| from dataclasses import dataclass | |||
There was a problem hiding this comment.
Faccio ad oggi molta fatica a capire cosa sono e quale sia la differenza tra una TrustSourceData e un TrustParameterData. In particolare TrustParameterData non mi sembra essere valorizzato da nessuna parte e non capisco come dovrei realizzare e usare questo layer di astrazione con implementazioni future.
Chiedo cortesemente se @PascalDR e/o @peppelinux mi possono aiutare con esempi su direct trust / federation / x509.
There was a problem hiding this comment.
La risposta pare essere fornita all'interno del docstring
non sono sicuro che questo livello di dettaglio nella divisione delle classi sia necessario
There was a problem hiding this comment.
unisco questa PR e ci torniamo sopra insieme
Zicchio
reviewed
Dec 18, 2024
Zicchio
reviewed
Dec 18, 2024
Zicchio
reviewed
Dec 19, 2024
peppelinux
requested changes
Dec 20, 2024
peppelinux
reviewed
Dec 23, 2024
peppelinux
reviewed
Dec 23, 2024
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.