Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/000001 swiftlint run script #20

Merged
merged 18 commits into from
Jul 27, 2019

Conversation

Harryyan
Copy link
Contributor

@Harryyan Harryyan commented Jul 24, 2019

为项目以及unit test添加lint库以及lint检查script.

@ChenYilong
Copy link
Member

这个是加入到 realm/SwiftLint
对应issue:#3

@ChenYilong
Copy link
Member

Travis CI - Branch Failing after 1m — Build Failed

@ChenYilong
Copy link
Member

建议把工程名改用通配符形式

@ChenYilong
Copy link
Member

方便日后修改工程名

@Harryyan Harryyan changed the base branch from master to develop July 26, 2019 20:56
@Harryyan
Copy link
Contributor Author

@ChenYilong 不是很明白 “工程名改用通配符形式” 这条。是修改pod文件里target name为通配符么?

类似:

target '.(or *)' do
swiftlint_pods
end

? (这种报错)

还是其他意思?

@0x1306a94 0x1306a94 merged commit 5638d7a into develop Jul 27, 2019
@0x1306a94 0x1306a94 deleted the feature/000001_Swiftlint_RunScript branch July 27, 2019 02:09
Copy link
Member

@ChenYilong ChenYilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

将 ClaretCacheDemo 换为通配符:${PROJECT_NAME}

- swift test
- swift build
- xcodebuild -scheme ClaretCacheDemo -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone XR,OS=12.1' build
- xcodebuild -workspace ClaretCacheDemo.xcworkspace -scheme ClaretCacheDemo -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone XR,OS=12.1' build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClaretCacheDemo换为通配符:${PROJECT_NAME}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

会在下一个pr中提交

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants