Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trimRecusively #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

trimRecusively #24

wants to merge 1 commit into from

Conversation

imJunXiang
Copy link

@imJunXiang imJunXiang commented Jul 25, 2019

CheckList

Thanks for considering to this repository. Before you submit your issue, please confirm these boxes are checked.

  • I have read 《[EN]Style guide for Swift repo [CN]Swift项目代码规范、规约选型》.
  • 我遵守一下 Merge 规则:邀请群组中任意一人进行review,即可合并。让 reviewer 在 PR 所在页面写下review意见表示通过,即可合并。最简单写一句 LGTM 也可以。不按照本规则执行,自己 PR 自己 Merge 并引入问题,会被收回 Merge 权限。

My issue:


What I have done:

@0x1306a94
Copy link
Contributor

@imJunXiang swiflint 还有⚠️, 请 执行下 swiftlint autocorrect

/// Stop when object is released
final func trimRecusively() {
DispatchQueue.global(qos: .utility).asyncAfter(deadline: .now() + autoTrimInterval) {[weak self] in
guard self != nil else {
Copy link
Contributor

@Harryyan Harryyan Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if let strongSelf = self {
strongSelf.trimInBackground()
strongSelf.trimRecusively()
}

这种写法呢?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants