完成KVStorage的dataBase和file部分 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAGESSE-CN
reviewed
Jul 29, 2019
Sources/ClaretCache/KVStorage.swift
Outdated
| #endif | ||
|
|
||
|
|
||
| enum KVStorageType { |
There was a problem hiding this comment.
在Swift中枚举应使用
enum KVStorageType {
case file
case sqlite
case mixed
}
SAGESSE-CN
reviewed
Jul 29, 2019
|
|
||
| extension UIApplication { | ||
| static func isAppExtension() -> Bool { | ||
| return IsAppExtension; |
SAGESSE-CN
reviewed
Jul 29, 2019
|
|
||
| import UIKit.UIApplication | ||
|
|
||
| var IsAppExtension: Bool { |
There was a problem hiding this comment.
这是计算属性! 每次访问都会重新计算! 请用var isAppExtension: Bool = {xxx}()
leung-c
reviewed
Jul 29, 2019
Sources/ClaretCache/KVStorage.swift
Outdated
| } | ||
| dbBindJoinedKeys(keys: keys, stmt: stmt, fromIndex: 1) | ||
| var items: Array<KVStorageItem>? | ||
| items = Array<KVStorageItem>() |
SAGESSE-CN
reviewed
Jul 29, 2019
| @@ -0,0 +1,29 @@ | |||
| // | |||
| // UIApplication+CCAdd.swift | |||
|
|
||
| import UIKit.UIApplication | ||
|
|
||
| var IsAppExtension: Bool { |
Sources/ClaretCache/KVStorage.swift
Outdated
| create index if not exists last_access_time_idx on manifest(last_access_time); | ||
| */ | ||
|
|
||
| class KVStorage: NSObject { |
Sources/ClaretCache/KVStorage.swift
Outdated
| #endif | ||
|
|
||
|
|
||
| enum KVStorageType { |
There was a problem hiding this comment.
在Swift中枚举应使用
enum KVStorageType {
case file
case sqlite
case mixed
}
Sources/ClaretCache/KVStorage.swift
Outdated
| } | ||
|
|
||
| deinit { | ||
| #if os(iOS) && canImport(UIKit) |
Sources/ClaretCache/KVStorage.swift
Outdated
| try fileMoveAllToTrash() | ||
| fileEmptyTrashInBackground() | ||
| } catch { | ||
| print("reset error: \(error)") |
Sources/ClaretCache/KVStorage.swift
Outdated
| } | ||
|
|
||
| fileprivate func fileRead(fileName: String) throws -> Data? { | ||
| return try Data.init(contentsOf: dataPath.appendingPathComponent(fileName)) |
Sources/ClaretCache/KVStorage.swift
Outdated
| trashPath = path.appendingPathComponent(kTrashDirectoryName) | ||
| dbPath = path.appendingPathComponent(kDBFileName) | ||
| do { | ||
| try FileManager.default.createDirectory(at: path, withIntermediateDirectories: true, attributes: nil) |
Sources/ClaretCache/KVStorage.swift
Outdated
| dbStmtCache = nil | ||
| repeat { | ||
| retry = false | ||
| let result = sqlite3_close(db!) |
Sources/ClaretCache/KVStorage.swift
Outdated
| fileprivate func dbJoinedKeys(_ keys: Array<Any>) -> String { | ||
| var string = "" | ||
| let max = keys.count | ||
| for i in 0..<max { |
leung-c
reviewed
Jul 29, 2019
Sources/ClaretCache/KVStorage.swift
Outdated
| } | ||
|
|
||
| deinit { | ||
| #if os(iOS) && canImport(UIKit) |
| let taskID = UIApplication.sharedExtensionApplication()?.beginBackgroundTask(expirationHandler: nil); | ||
| dbClose() | ||
| #if os(iOS) && canImport(UIKit) | ||
| if let task = taskID { |
There was a problem hiding this comment.
建议：上面的taskID不需要单独定义，可简化为：if let taskId = UIApplication.sharedExtensionApplication()?.beginBackgroundTask(expirationHandler: nil)。
# Conflicts: # Sources/ClaretCache/MemoryCache.swift
HanCongYang
reviewed
Jul 30, 2019
Sources/ClaretCache/KVStorage.swift
Outdated
| guard Bundle.main.bundleURL.pathExtension != "appex" else { | ||
| return false | ||
| } | ||
| guard let app = NSClassFromString("UIApplication"), app.value(forKey: "shared") != nil else { |
There was a problem hiding this comment.
guard let app = NSClassFromString("UIApplication"), app.value(forKey: "shared") != nil else 有没有纯swift方案呢？感觉这么写太oc了.
There was a problem hiding this comment.
这块还没进行测试呢，搞不好有问题，之前网上搜了一波，有些说要加bundle的名字，也不知道对不对
|
LGTM。 已完成初步修改，因disk开发需求，进行合并 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckList
Thanks for considering to this repository. Before you submit your issue, please confirm these boxes are checked.
My issue:
What I have done: