Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

按照pr意见修改，并加入trim方法 #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

按照pr意见修改，并加入trim方法 #36

wants to merge 2 commits into from

Conversation

kevinlzh1108
Copy link

CheckList

Thanks for considering to this repository. Before you submit your issue, please confirm these boxes are checked.

  • I have read 《[EN]Style guide for Swift repo [CN]Swift项目代码规范、规约选型》.
  • 我遵守一下 Merge 规则：邀请群组中任意一人进行review，即可合并。让 reviewer 在 PR 所在页面写下review意见表示通过，即可合并。最简单写一句 LGTM 也可以。不按照本规则执行，自己 PR 自己 Merge 并引入问题，会被收回 Merge 权限。

My issue:

What I have done:

@EmingK
Copy link
Member

EmingK commented Aug 6, 2020

顺带一提，可以通过 rebase 的方式把多个 commit 合并成一个，这样就不用关闭旧的 pr 并且保持提交记录干净啦

EmingK
EmingK approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@EmingK EmingK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmingK EmingK EmingK approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinlzh1108 @EmingK