Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent introduction of new property skill status property #85

Open
Weltraumschaf opened this issue Mar 25, 2022 · 0 comments
Open

Consistent introduction of new property skill status property #85

Weltraumschaf opened this issue Mar 25, 2022 · 0 comments
Labels
backend bug Something isn't working frontend

Comments

@Weltraumschaf
Copy link
Member

Weltraumschaf commented Mar 25, 2022 •
edited
Loading

We introduced the new property TeamSkillDTO#skillStatus as @NotNull. It must contain one of:

  • SkillStatus#OPEN
  • SkillStatus#ACHIEVED
  • SkillStatus#EXPIRING
  • SkillStatus#EXPIRED
  • SkillStatus#IRRELEVANT

We must investigate the code base and identify the places where we must maintain this new property.
@Weltraumschaf Weltraumschaf mentioned this issue Mar 25, 2022
Closed
@Weltraumschaf Weltraumschaf added bug Something isn't working frontend backend labels Mar 25, 2022
Weltraumschaf added a commit that referenced this issue Mar 25, 2022
@Weltraumschaf
#79 Fix various NPEs on update an achieved skill as completed
3f70e9a 
Various problems:

1. There is a new DTO created which have both the team and skill
   as null by default. Trying to set the ID on them results in NPE.
2. New introduced field sklillStatus is null by default, but must
   not be null

The first problem is solved by resolving the team andskill according
to their ids. If either of them is not present (does not exist) the
method exits. An empty DTO is returned to prevent NPE by callers.

The second problem is solved by assigning Skillstatus#ACHIEVED.
New issue[1] created bc we must maintain this new field consistent
in the whole code base.

1: #85

Signed-off-by: Sven Strittmatter <[email protected]>
@rseedorff rseedorff changed the title Consistent introduction of new property sklil status property Consistent introduction of new property skill status property Apr 7, 2022
@Weltraumschaf Weltraumschaf mentioned this issue Jun 9, 2022
Closed
Amar-Bolkan added a commit that referenced this issue Jun 13, 2022
@Amar-Bolkan
Issue #85: Set SkillStatus == ACHIEVED for team_skills in demo data
5c42c73
Amar-Bolkan added a commit that referenced this issue Jun 13, 2022
@Amar-Bolkan
Issue #85: Set SkillStatus to value received in AchievableSkillDTO
6ea6f1d 
This was previously hardcoded to always assign SkillStatus.ACHIEVED

The change in TeamSkillDTO is done to prevent a type error at
runtime. Previously the class used the SkillStatus enum generated
by jhipster and not our custom one, which is returned by the
getSkillStatus method.
Amar-Bolkan added a commit that referenced this issue Jun 13, 2022
@Amar-Bolkan
Issue #85: Use skillstatus instead of completedAt to display UI Element
fc0d513
Amar-Bolkan added a commit that referenced this issue Jun 13, 2022
@Amar-Bolkan
Issue #85: Set correct skillStatus, when skill complete / uncomplete …
f2dcc34 
…is clicked
Amar-Bolkan added a commit that referenced this issue Jun 13, 2022
@Amar-Bolkan
Issue #85: Add missing import
d611f80
rseedorff added a commit that referenced this issue Jun 16, 2022
@rseedorff
#85 #114 Fixing broken icons an missleading color codes
a1bf037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Weltraumschaf