Adding uuid to dataset version
#587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
bd56209
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://55ab826c.datachain-documentation.pages.dev |
| Branch Preview URL: | https://ilongin-578-dataset-uuid.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 100 100
Lines 9993 9997 +4
Branches 1356 1356
=======================================
+ Hits 8777 8781 +4
Misses 873 873
Partials 343 343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattseddon
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed unique identified of specific dataset, as name + version is not strong enough. User can remove dataset and re-create it with the same name + version.
This is needed in scenarios like pulling dataset from remote where we need to check if dataset already exists in user's local DB where it can be named differently or have different version, but it's the same dataset regardless.