Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding uuid to dataset version #587

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Adding uuid to dataset version #587

merged 3 commits into from
Nov 13, 2024

Conversation

ilongin
Copy link
Contributor

@ilongin ilongin commented Nov 12, 2024

We needed unique identified of specific dataset, as name + version is not strong enough. User can remove dataset and re-create it with the same name + version.

This is needed in scenarios like pulling dataset from remote where we need to check if dataset already exists in user's local DB where it can be named differently or have different version, but it's the same dataset regardless.

@ilongin ilongin marked this pull request as draft November 12, 2024 10:25
@ilongin ilongin linked an issue Nov 12, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Nov 12, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd56209
Status: ✅  Deploy successful!
Preview URL: https://55ab826c.datachain-documentation.pages.dev
Branch Preview URL: https://ilongin-578-dataset-uuid.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (b0e3a32) to head (bd56209).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files         100      100           
  Lines        9993     9997    +4     
  Branches     1356     1356           
=======================================
+ Hits         8777     8781    +4     
  Misses        873      873           
  Partials      343      343           
Flag Coverage Δ
datachain 87.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilongin ilongin marked this pull request as ready for review November 12, 2024 14:25
@ilongin ilongin requested a review from a team November 12, 2024 14:25
@ilongin ilongin merged commit c5eb1d6 into main Nov 13, 2024
38 checks passed
@ilongin ilongin deleted the ilongin/578-dataset-uuid branch November 13, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unique id to dataset version
2 participants