Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(agg): add an example with custom UDF spec #586

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

shcheklein
Copy link
Member

Add an explicit example on an alternative syntax for agg (I spent some time to figure our the appropriate signature).

@shcheklein shcheklein self-assigned this Nov 12, 2024
@shcheklein shcheklein added the documentation Improvements or additions to documentation label Nov 12, 2024
@shcheklein shcheklein requested a review from a team November 12, 2024 02:30
Copy link

cloudflare-workers-and-pages bot commented Nov 12, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1651587
Status: ✅  Deploy successful!
Preview URL: https://3fefb30a.datachain-documentation.pages.dev
Branch Preview URL: https://docs-agg-add-example.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (b0e3a32) to head (1651587).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files         100      100           
  Lines        9993     9993           
  Branches     1356     1356           
=======================================
  Hits         8777     8777           
  Misses        873      873           
  Partials      343      343           
Flag Coverage Δ
datachain 87.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ilongin ilongin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 small comments

src/datachain/lib/dc.py Outdated Show resolved Hide resolved
src/datachain/lib/dc.py Outdated Show resolved Hide resolved
@shcheklein shcheklein merged commit 02e8efe into main Nov 12, 2024
38 checks passed
@shcheklein shcheklein deleted the docs/agg-add-example branch November 12, 2024 21:18
@shcheklein
Copy link
Member Author

thanks @ilongin for reviewing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants