remove cosine_distance/euclidean_distance impl #752
+3
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in favor of usearch's.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 87.51% 87.37% -0.15%
==========================================
Files 114 113 -1
Lines 10945 10920 -25
Branches 1501 1501
==========================================
- Hits 9579 9541 -38
- Misses 991 1000 +9
- Partials 375 379 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattseddon
reviewed
Dec 27, 2024
| @@ -217,23 +217,6 @@ def register_user_defined_sql_functions() -> None: | |||
| # Register optional functions if we have the necessary dependencies | |||
| # and otherwise register functions that will raise an exception with | |||
| # installation instructions | |||
| try: | |||
There was a problem hiding this comment.
from memory: we need this as a fallback because usearch is not available on Windows - unum-cloud/usearch#427
There was a problem hiding this comment.
There was a problem hiding this comment.
description on that PR should shed some light on the approach
|
@skshetry what is the status of this? |
1 similar comment
|
@skshetry what is the status of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in favor of usearch's.