meta.from_info: use positional args (#558)

iterative · Aug 13, 2024 · 8a9033d · 8a9033d
1 parent b3e73b0
commit 8a9033d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 14 deletions.
diff --git a/src/dvc_data/hashfile/checkout.py b/src/dvc_data/hashfile/checkout.py
@@ -368,7 +368,7 @@ def checkout(  # noqa: PLR0913
     except CheckoutError as exc:
         failed.extend(exc.paths)
 
-    if diff and state:
+    if (diff or relink) and state:
         state.save_link(path, fs)
 
     if failed or not diff:

diff --git a/src/dvc_data/hashfile/meta.py b/src/dvc_data/hashfile/meta.py
@@ -64,19 +64,20 @@ def from_info(cls, info: dict[str, Any], protocol: Optional[str] = None) -> "Met
             version_id = info.get("generation")
 
         return Meta(
-            isdir=info["type"] == "directory",
-            size=info.get("size"),
-            isexec=is_exec(info.get("mode", 0)),
-            version_id=version_id,
-            etag=etag,
-            checksum=checksum,
-            md5=info.get("md5"),
-            inode=info.get("ino"),
-            mtime=info.get("mtime"),
-            remote=info.get("remote"),
-            is_link=info.get("islink", False),
-            nlink=info.get("nlink", 1),
-            destination=info.get("destination"),
+            info["type"] == "directory",
+            info.get("size"),
+            None,
+            is_exec(info.get("mode", 0)),
+            version_id,
+            etag,
+            checksum,
+            info.get("md5"),
+            info.get("ino"),
+            info.get("mtime"),
+            info.get("remote"),
+            info.get("islink", False),
+            info.get("destination"),
+            info.get("nlink", 1),
         )
 
     @classmethod