index: don't forget to reset _cache on close

iterative · Dec 22, 2023 · 97d8e59 · 97d8e59
1 parent 9b3e411
commit 97d8e59
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/dvc_data/index/index.py b/src/dvc_data/index/index.py
@@ -138,6 +138,10 @@ def delete_node(self, key):
         self._cache.pop(key, None)
         super().delete_node(key)
 
+    def close(self):
+        self._cache = {}
+        super().close()
+
 
 class Storage(ABC):
     def __init__(self, key: "DataIndexKey"):

diff --git a/tests/index/test_index.py b/tests/index/test_index.py
@@ -431,11 +431,17 @@ def test_open(tmp_path):
     assert index[key] == entry2
 
     index.commit()
+    assert index._trie._cache
     index.close()
+    assert not index._trie._cache
 
     index = DataIndex.open(path)
     index[key] = entry2
     assert index[key] == entry2
 
     index[key] = entry1
     assert index[key] == entry1
+
+    assert index._trie._cache
+    index.close()
+    assert not index._trie._cache