-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guide: update comparing exps #4651
Conversation
} | ||
} | ||
``` | ||
## Compare plots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like it should be more prominent tbh, part of the compare functionality ... I wonder if should include some screenshots/previews at least.
Also, is it the right title for end users - "compare plots"? We are still comparing metrics, right? Just in a different format. What is the easiest for people to understand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like it should be more prominent tbh, part of the compare functionality ... I wonder if should include some screenshots/previews at least.
Added a more expansive section. PTAL.
I didn't want to repeat https://dvc.org/doc/user-guide/experiment-management/visualizing-plots#comparing-plots, but I think it's better even if it's slightly repetitive.
Also, is it the right title for end users - "compare plots"? We are still comparing metrics, right? Just in a different format. What is the easiest for people to understand?
🤔 I think it's easy for people to understand regardless of the title. Plots aren't a novel concept and neither is comparing them as part of experiment tracking, so no strong opinion from me, but I doubt it's too important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plots aren't a novel concept and neither is comparing them as part of experiment tracking, so no strong opinion from me, but I doubt it's too important.
Yep, I think my question is more about even - do we need a separate section at all for this? (since it's nothing special - should it be just part of the main section, w/o subtitles, etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, makes sense. I don't quite have a great idea for how to reorganize it to bring it together with the table, but open to ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, nw, it's not a blocker at all...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are Studio tabs planned as a followup?
Good question. I didn't plan on it, but I now added a section here where I mention it. Since we have guides for sharing experiments and comparing in Studio, I'm not sure I want to cover it in depth, and I'm also not sure I want it as another "tab" since otherwise this guide is focused on the local experience and the need for Studio feels like a slightly different use. We also have more space to explain these differences compared to get started. |
No strong opinion, I am just not sure whether it helps or hurts to have separate comparing experiments in the Studio guide (i.e. https://dvc-org-exp-compare-1pcs47e2en.herokuapp.com/doc/studio/user-guide/projects-and-experiments/visualize-and-compare). |
It's linked here. Do you think we should consolidate them into one page? Let's follow up and discuss how we want to structure the dvc/studio content, especially with the upcoming changes of dvcx. |
Merging but happy to keep making improvements as follow ups. |
Updates to the guide for comparing experiments.
Main points: