fix test_daemon.py::test_analytics flakiness #10523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
force-pushed
the
debug-ci
branch
4 times, most recently
from
b1afac7
to
98ed7b8
Compare
Turns out `iterative-telemetry` spends a long time trying to generate an id. Sometimes it gets frozen for a long time (>30s).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10523 +/- ##
==========================================
- Coverage 90.58% 90.57% -0.02%
==========================================
Files 503 503
Lines 39126 39148 +22
Branches 5647 5648 +1
==========================================
+ Hits 35442 35457 +15
- Misses 3007 3016 +9
+ Partials 677 675 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
iterative-telemetryspends a long time trying to generate an id. Sometimes it gets frozen for a long time (>30s).