Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repro: remove on_unchanged kwarg and _repro_callback #9674

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

skshetry
Copy link
Member

No description provided.

@skshetry skshetry requested a review from pmrowla June 30, 2023 03:50
@skshetry skshetry changed the title repro: remove on_unchaged kwarg and _repro_callback repro: remove on_unchanged kwarg and _repro_callback Jun 30, 2023
@skshetry skshetry added refactoring Factoring and re-factoring skip-changelog Skips changelog labels Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (6e6d925) 90.64% compared to head (154aa6d) 90.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9674      +/-   ##
==========================================
- Coverage   90.64%   90.63%   -0.02%     
==========================================
  Files         472      472              
  Lines       36289    36280       -9     
  Branches     5221     5218       -3     
==========================================
- Hits        32895    32882      -13     
- Misses       2810     2812       +2     
- Partials      584      586       +2     
Impacted Files Coverage Δ
dvc/repo/experiments/executor/base.py 80.05% <100.00%> (-0.26%) ⬇️
dvc/repo/reproduce.py 96.26% <100.00%> (+0.76%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry merged commit 36ec25f into iterative:main Jun 30, 2023
18 of 20 checks passed
@skshetry skshetry deleted the remove-on-unchanged branch June 30, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Factoring and re-factoring skip-changelog Skips changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants