Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just additional docs for the dagascii.draw function. Specifically documents the return value type and it adds a doctest to illustrate what the function does.
I'm a big fan of text representations of graphs. So when I was browsing the code and saw this I got excited. But while reading the code I wondered: what does this graph look like? I went through the effort of constructing a small example and printed it for myself. Certainly a nifty way to visualize a DAG. I think it would be nice if the code was able to provide a gist of that output without requireing the user to construct an example, and I think adding a doctest here provides that.
Not sure how maintainers feel about doctests -- I see the repo has some of them, but not too many. As I learn codebases I often need to construct mwe to illustrate what a piece does for myself, so if the maintainers are interested, I'll continue submitting small PRs that add doctests like these as I generate them for myself.