repro: do not autostage stage files #9689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic is now moved to experiments, where it tracks all the stage related files itself. The `_get_stage_files()` has been modified to also return lockfile path, so that it can be staged, and has been moved to `stage/utils.py`, and out of `reproduce.py`. Fixes iterative#9688.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9689 +/- ##
==========================================
- Coverage 90.55% 90.54% -0.01%
==========================================
Files 480 480
Lines 36353 36359 +6
Branches 5223 5226 +3
==========================================
+ Hits 32918 32923 +5
Misses 2849 2849
- Partials 586 587 +1
☔ View full report in Codecov by Sentry. |
pmrowla
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is now moved to experiments, where it tracks all the stage related files itself. The
_get_stage_files()has been modified to also return lockfile path, so that it can be staged, and has been moved tostage/utils.py, and out ofreproduce.py.Fixes #9688.