-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a sensible value for localStorage.size
#435
Conversation
what is it used for in our cluster? if we don't have a local storage, what kind of storage is it using instead? |
@shcheklein The node storage. Node allows to allocate storage until it will node storage will not be lower that 10% of the total disk space or 10GB(whichever is smaller) |
@0x2b3bfa0 I would disable it for studio-worker as well |
so, what was the localStorage used for ? why is it needed at all? (can we clarify this in helm comments / docs)? |
|
localStorage
by defaultlocalStorage.size
@shcheklein / @mjasion, better now? |
|
Not by default; it'll be ephemeral.
It would use the default |
I mean the docs / or helm comments. We assume that help is used by customers, right? We should try to put some explanations if possible (not sure if we do this atm, but we were getting negative feedback about this recently). But even for me, deploying this- It's hard to understand the purpose, if I need this or not, etc.
okay, so, space guarantee is the only thing here? (just to make sure) |
Yes, basically it guarantees |
Right; let me try to fix it.
Long story short, it's needed to initialize & store virtual environments. |
Happier? helm-charts/charts/studio/values.yaml Line 706 in 8b0df92
|
Well :) nobody outside would understand this ... even internal users - some people will not be able to connect the dots. Anyways, that's fine considering that we don't have much of the docs for the rest of the Helm anyways. It should be a separate issue / epic if we can get to it at some point. Not a blocker, @0x2b3bfa0 . Thanks for taking care of this. |
It's problematic on self-hosted deployments, especially with the
1Gi
default size; let's keep it for people who need it and know what they're doing?Alternatively, perhaps increase size to
20Gi
as well?