Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS coding challenge submitted for assessment (Joel Chavoya) #37

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Serlych
Copy link

@Serlych Serlych commented Dec 18, 2018

  • "I need to be able to access the CRUD capabilities of the lists through a RESTful API, json based, from external domains"

I wasn't really sure how to implement this, the way I understood it was using an external database, but my CRUD operations were confusing me a bit, so I decided to stop instead of writing nonsense code.

  • "I need an exposed CRUD API to affect the Lists and Items entities using the correct HTTP verbs for each: create, update, remove, fetch all and fetch by id should be supported for lists and items (10 endpoints total)"

I wasn't able to get it right for every operation and I think my data structure does not support id's, I was a bit confused in this part.

  • "I need middleware to happen on each request validating that the user has a cookie named "auth" or not (log the value to output, we are not managing authentication of any kind just yet)"
  • "I need a test suite testing the endpoints"
  • "I need a test suite testing the middleware covering the cases where the user has a cookie named "auth", a cookie with another name or no cookie at all"

I wasn't able to complete the test suite on time, so I chose to not include it at all, and also I wasn't able to do enough research to implement cookies on my application on time and some explanations were a bit confusing, since I have never used cookies before.

I would totally love and appreciate some feedback on my code if that were possible, thank you for the challenge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants