Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter_header.php #1092

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThaMunsta
Copy link
Contributor

Change to filters for better experience and address an issue where by default its difficult to see new stripe expenses since they are added as "tomorrow" date and many filters exclude tomorrow. This will also take into account the users preference on start of week.

Change to filters for better experience and address an issue where by default its difficult to see new stripe expenses since they are added as "tomorrow" date and many filters exclude tomorrow. This will also take into account the users preference on start of week.
Copy link

@wrongecho
Copy link
Collaborator

Test these changes at: https://defaultfilter1092.pr-review.itflow.org
(automatic message)

@ThaMunsta
Copy link
Contributor Author

A few edge cases still exist here. I believe if "today" is a Sunday (or Monday depending on user preferences) the this week and last week filters will be weird but otherwise I feel this has better filtering in most situations. Open to suggestions though.

@johnnyq
Copy link
Collaborator

johnnyq commented Oct 29, 2024

Hey @ThaMunsta I belive your timestamps might be in UTC instead of your Timezone, that could be why its off a bit

@ThaMunsta
Copy link
Contributor Author

Hey @johnnyq thanks, is that something I should update somewhere? The payment came through with the right date just the fees were put on the following day.
I still think this PR contains some nice QOL changes but I can just keep them in my local if they don't make sense to implement upstream. I could also make changes if you have any feedback. All good either way just love the software 😁

@wrongecho
Copy link
Collaborator

I really like the ability to respect the Monday/Sunday week start preference if nothing else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants