Stop using Source Sans Pro intermittently for some pages #1128
+25
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Test these changes at: https://fonttidy1128.pr-review.itflow.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to dig into merging the login flows and I noticed that we're still calling Source Sans Pro direct from Google. In global.css we define Sans Serif as the global font, I see no reason why we should have a slightly different font just for the login page.
It looks like it was originally added sometime around when the login page was styled after being built and just never updated (here?).
By removing this we can also remove all references to fonts.googleapis.com fonts.gstatic.com as part of our CSP effort (#1036).