Fix client delete function #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test these changes at: https://fixclientdelete725.pr-review.itflow.org |
|
Kudos, SonarCloud Quality Gate passed!
|
|
This looks fantastic!! =] I like that you have to enter the client name in to continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix + Enhancement
When testing the recent changes, I noticed the restored client delete modal wasn't properly directing people to the
post.php?delete_clientpage - it would just hang after you click Yes.Whilst working on fixing this using the new confirmation modals, I figured that deleting an entire clients data shouldn't be as easy as clicking "Yes", so restored the old confirmation dialog where you're required to enter the client name (complete with CSRF).
Hope you agree that this is the best way forward for this specific extremely destructive function! :)