Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Templates #755

Closed
wants to merge 9 commits into from
Closed

Service Templates #755

wants to merge 9 commits into from

Conversation

o-psi
Copy link
Contributor

@o-psi o-psi commented Oct 12, 2023

This PR adds all the groundwork for service templates, additionally, lets you assign a price to the service(no function yet)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
20.0% 20.0% Duplication

@wrongecho
Copy link
Collaborator

Test these changes at: https://servicetemplates755.pr-review.itflow.org
(automatic message)

@johnnyq
Copy link
Collaborator

johnnyq commented Oct 15, 2023

Hello @o-psi Instead of creating a whole new table since most of the fields are the same as a service template
Add a tinyint (1) field to services and call it service_template: 1 meaning its a template 0 meaning its not.
We did the same with document templates, vendor templates and software licenses templates. This can be replicated here as well.

@o-psi o-psi marked this pull request as draft October 15, 2023 16:33
@wrongecho
Copy link
Collaborator

Can I suggest we don't include anything about pricing/service costs until it's actually decided how that will work and is fully functional? It just seems to confuse users and we get "bug" posts.

@o-psi o-psi closed this Oct 15, 2023
@o-psi o-psi deleted the service-templates branch October 15, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants