-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort invoice items #762
Sort invoice items #762
Conversation
Test these changes at: https://Invoiceitemsorder762.pr-review.itflow.org |
database_updates.php
Outdated
$item_order_id = 1; | ||
foreach ($sql_invoice_items as $row) { | ||
$item_id = $row['item_id']; | ||
mysqli_query($mysqli, "UPDATE invoice_items SET item_order_id = '$item_order_id' WHERE item_id = '$item_id'"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update each invoice item and give it a, item order id
Nice work, you dont slow down hahhaa but can we rename item_order_id to just item_order we use id to reference items in multi tables and it would cause a little bit of confusion |
@johnnyq Done :) |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
So far so good on the item order I pulled it in it looks fantastic but needs some more functionality love Some Logic to add
Of course once this is super stable we should replicate this everywhere recurring invoices, quotes, quote to invoice, cron generated invoices from recurring etc. Great job! |
This PR adds the ability to order invoice items.
I know we wanted to do draggable, but I need to practice JS more for that.