Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled tickets (appointments) #867

Closed
wants to merge 8 commits into from
Closed

Scheduled tickets (appointments) #867

wants to merge 8 commits into from

Conversation

o-psi
Copy link
Contributor

@o-psi o-psi commented Jan 18, 2024

This pull request includes the following changes:

  • Added a new column ticket_schedule to the tickets table.

  • Added a new modal editTicketScheduleModal for editing the scheduled time of a ticket.

  • Displayed the scheduled time of a ticket in the ticket details section.

  • Added a link to edit the scheduled time in the ticket details section.

  • Added the tickets to the calendar in the future.

This is seen to be used with appointments in the future, hopefully linking to an external calendar.
TODO: Send an ical email to add the event to outlook calendars, or sync calendars another way.

@wrongecho
Copy link
Collaborator

Test these changes at: https://scheduledtickets867.pr-review.itflow.org
(automatic message)

@johnnyq
Copy link
Collaborator

johnnyq commented Jan 19, 2024

@o-psi We currently already have scheduled tickets (Im sure you already know that), is this different than that or set to replace or merge with it by integrating into one table called tickets?

@o-psi
Copy link
Contributor Author

o-psi commented Jan 19, 2024

The current 'scheduled tickets' is better described as 'reoccurring tickets'.

Rather, this is for when a ticket exists, but the work for it is scheduled sometime in the future.

@johnnyq
Copy link
Collaborator

johnnyq commented Jan 19, 2024

I see now, technically scheduled tickets is named improperly due to its function.

So heres a thought what about using scheculed tickets tables and views/edit/create but being able to select Just once under frequency, Im open to your opinions and suggestions on this one

@o-psi
Copy link
Contributor Author

o-psi commented Jan 22, 2024

Originally, that is how i thought it would work best aswell, and maybe we can add a link there. But I think we need to rename scheduled tickets to recurring tickets, then it will no longer make sense to have this feature under a Once option. Things do not reoccur once...

Maybe I can spend some time in the docs explaining it.

@johnnyq
Copy link
Collaborator

johnnyq commented Jan 23, 2024

hmmm im almost wondering about merging scheduled (aka recurring tickets into the tickets table and just make it one entity with flags indicating recurring, scheduled or regular ticket.

@wrongecho
Copy link
Collaborator

What's being proposed here and the existing scheduled/recurring tickets are entirely separate in my view. This is about scheduling a future time to work on a ticket.

I'd support renaming scheduled tickets to recurring, but perhaps this function should be part of the Pending/On Hold flow instead?
Tickets would automatically be moved back to an open / working state once the scheduled time arrives. Ideal for planned site visits, new starters, OOH work, etc.

@o-psi
Copy link
Contributor Author

o-psi commented Jan 24, 2024

Wrong Echo, perfectly stated.

I support adding a link on the pending to open this modal when set to pending aswell.

@o-psi
Copy link
Contributor Author

o-psi commented Feb 2, 2024

Im gonna get to work on the proposed changes tomorrow.

Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@o-psi
Copy link
Contributor Author

o-psi commented Feb 8, 2024

How do we want to include this into the pending or onhold flow?

@johnnyq
Copy link
Collaborator

johnnyq commented Feb 8, 2024

Lets hold off on the pending and on-hold flow for right now and play around with what you got
I reviewed the code Its ready to be reeled in except for the Database changes need to be updated as we recently added AI items to the DB. Along with new DB Dump db.sql for new installs

@o-psi o-psi closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants