Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credits #897

Closed
wants to merge 4 commits into from
Closed

Credits #897

wants to merge 4 commits into from

Conversation

o-psi
Copy link
Contributor

@o-psi o-psi commented Feb 27, 2024

This pull request adds credits functionality on overpayment or over bulk payment.

@wrongecho
Copy link
Collaborator

Test these changes at: https://credits897.pr-review.itflow.org
(automatic message)

@johnnyq
Copy link
Collaborator

johnnyq commented Feb 28, 2024

Nice work @o-psi , although I haven't had a personal need for credits yet this can come in handy for other business utilizing ITFlow and is very much needed, however this really needs to be thoroughly tested especially on how it will affect income reporting and projected income based of the invoice amounts.

@o-psi
Copy link
Contributor Author

o-psi commented Feb 28, 2024

We are putting this through its paces now.

@johnnyq
Copy link
Collaborator

johnnyq commented Feb 28, 2024

Excellent lets leave it open for a week, the code appears fine

@wrongecho
Copy link
Collaborator

Closes #193

@johnnyq
Copy link
Collaborator

johnnyq commented Mar 7, 2024

@o-psi Everything appears to be good, have you guys been using it much on your end and how has your testing been so far with the credits system?

@wrongecho Wanted to check with you to take peek as well, it looks good to me

Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
11.8% Duplication on New Code

See analysis details on SonarCloud

@o-psi
Copy link
Contributor Author

o-psi commented Mar 8, 2024

@johnnyq We haven't had the need to make any credits yet.

@o-psi o-psi closed this Mar 8, 2024
@wrongecho wrongecho mentioned this pull request Mar 10, 2024
@o-psi o-psi deleted the credits branch August 23, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants