Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct short options for --formats and --fontName in help #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juliangilbey
Copy link

Summary

The output of webfont --help currently includes -f, --fontName and -r, --formats, but these don't match the definitions later in the file, so -f myfont produces no output (as myfont is not a valid format). This patch corrects the help message to match the definitions.

How to test

Describe the tests that you ran to verify your changes:

  1. Run webfont --help.
  2. Check if the lines now read -u, --fontName and -f, --formats

Checklist

  • I have added corresponding labels to this PR (like bug, enhancement...);
  • My commits follow the Conventional Commits 1.0 Guidelines;
  • My code follows the style guidelines of this project;
  • I have performed a self-review of my own code;
  • I have mapped technical debts found on my changes;
  • I have made changes to the documentation (if applicable);
  • My changes generate no new warnings or errors;

@juliangilbey juliangilbey force-pushed the correct-cli-short-options-help branch from 88b861d to b4366ff Compare February 14, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant