Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation configuration #140

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Update documentation configuration #140

merged 3 commits into from
Oct 15, 2024

Conversation

daneah
Copy link
Member

@daneah daneah commented Oct 15, 2024

This change is a: (check at least one)

  • Bugfix
  • Feature addition
  • Code style update
  • Refactor
  • Release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the:

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite passing?
  • Code coverage maximal?
  • Changelog up to date?

What does this change address?

The documentation build currently results in a few warnings, and consuming projects that were trying to build documentation which linked to apiron would fail, as Sphinx attempts to run str(cls()) for referenced objects and the __str__ method for Service would access domain, which is not set through an initializer but is instead expected to exist on the Service class definition before instantiation.

How does this change work?

  • Use new data type for source_suffix
  • Update intersphinx mappings to new locations
  • Use fallback value for domain in Service.__str__

- Use new data type for `source_suffix`
- Update intersphinx mappings to new locations
- Set class member `domain` of `Service` to an initial value.
  Consuming projects trying to build documentation that linked to apiron
  would fail, as Sphinx attempts to run `str(cls())` for objects and the
  `__str__` method for `Service` would access `domain`, which is not set
  through an initializer but is instead expected to exist on the
  `Service` class definition before instantiation.
@daneah daneah added 🐛 bug Something isn't working ⛏ chore Something that's just got to be done! labels Oct 15, 2024
@daneah daneah merged commit 6236cc8 into dev Oct 15, 2024
10 checks passed
@daneah daneah deleted the chore/update-docs-config branch October 15, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⛏ chore Something that's just got to be done!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants