Skip to content

Commit

Permalink
Radio button: Update SVG to be aria-hidden (#829)
Browse files Browse the repository at this point in the history
* fix(radio): remove aria-label and add aria-hidden

* Update .changeset/silver-starfishes-look.md

Co-authored-by: Brent Swisher <[email protected]>

---------

Co-authored-by: Brent Swisher <[email protected]>
  • Loading branch information
sirrah-tam and brentswisher authored Oct 30, 2024
1 parent 0717dd8 commit 62a6b66
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/silver-starfishes-look.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': patch
---

Update the radio button SVG icon to use aria-hidden instead of aria-label
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class PharosRadioButton extends FormMixin(FormElement) {
height="24"
class="input__icon"
role="img"
aria-label="radio button"
aria-hidden="true"
focusable="false"
@click="${this._handleClick}"
>
Expand Down

0 comments on commit 62a6b66

Please sign in to comment.