fix(modal): remove overflow property that causes unnecessary scrollbars #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-iden
requested review from
sirrah-tam,
jialin-he and
mtorres3
and removed request for
a team
🦋 Changeset detectedLatest commit: ed1573a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
daneah
reviewed
Oct 28, 2024
.tool-versions
Outdated
| @@ -1 +1 @@ | |||
| nodejs 20.11.1 | |||
| nodejs 20.18.0 | |||
There was a problem hiding this comment.
I recommend we move to Node 22 if possible since that's what the docs say we should be using, and that we update the docs, maybe to remove reference to a version at all.
There was a problem hiding this comment.
Interesting. I was curious and it looks like node 22 LTS support starts tomorrow. I can bump that and clean up the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
#826
How does this change work?
Remove overflow property for an element that will never overflow
Additional context