Add UDP group #480
Open
Add UDP group #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add UDP group IPV4 & IPV6 join group, leave group.
ithewei
reviewed
Jan 5, 2024
| mreq.imr_interface.s_addr = inet_addr(local_host); | ||
| return setsockopt(sockfd, IPPROTO_IP, IP_DROP_MEMBERSHIP, (const char*)&mreq, sizeof(mreq)); | ||
| } | ||
| HV_INLINE int udp_joingroupv6(int sockfd, const char* group, ULONG interface) { |
There was a problem hiding this comment.
ULONG是windows平台下特有的类型定义，其它平台没有，CI已经报错了
ithewei
reviewed
Jan 5, 2024
| } | ||
|
|
||
| // join group | ||
| int joinGroup(const char* g){ |
There was a problem hiding this comment.
看了下，就添加了joinGroup、leaveGroup两个方法，其它代码都是拷贝自UdpServer，不如直接加在UdpServer里，没必要单独搞个UdpGroup类了吧
|
这个确实是在UdpServer的基础上添加了joinGroup、leaveGroup两个方法。但是我觉得对于UDP组播来说，接收的不一定是要做为服务器存在，可能它只是建立通道要接收数据，处理并执行，而不是向服务器一样处理后再将数据送出去。 |
|
现在的IPV6组播在linux和mac/ios上没有通过编译，我也用不到，想把它去掉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add UDP group IPV4 & IPV6 join group, leave group.