Fix broken endpoint #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am guessing the tests will break but I need to move on for now with normal transport. Will come back if I have time or feel free to takeover if the concept is sound thank you. |
hegeh0g
approved these changes
Nov 2, 2023
|
@ferry-colin I could not get it to work at all using the v1 url - logs were just not getting sent so it is not only about the region. This pr matches the docs on datadog's site too for the current implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like this needs to happen now unless I am mistaken. Someone can take this over if the general premise is right. As-is the lib doesn't work for me and it contradicts the instructions of winston on dd website. Using a normal Winston transport on the newer url pattern described in the docs does work.